Skip to content

Add extended debug & performance optimized distro variants #140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
vkraleti wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add extended debug & performance optimized distro variants #140

vkraleti wants to merge 3 commits into from
+15 −0

Conversation

@vkraleti
Copy link
Contributor

@vkraleti vkraleti commented Jan 20, 2026

Add qcom-distro-extended-debug and qcom-distro-optimized-perf distro
variants to enable builds with additional debugging and performance optimization
features respectively.

@vkraleti vkraleti mentioned this pull request Jan 20, 2026
Open
@vkraleti
qcom-base: inherit distrooverrides bbclass
a157240 
Add `distrooverrides` to the INHERIT list to convert selected
DISTRO_FEATURES into overrides with a matching name prefixed by `df-`.
This simplifies writing .bb and .bbappend files that need to adjust task
signatures or behavior when a given feature is enabled.

Signed-off-by: Viswanath Kraleti <viswanath.kraleti@oss.qualcomm.com>
@vkraleti
distro: add extended debug enabled distribution variant
a29ccff 
Add the qcom-distro-extended-debug distro variant, which enables
builds with additional debugging features enabled through the
`extended-debug` DISTRO_FEATURE. This variant is useful for
enhanced debug instrumentation and tooling.

Signed-off-by: Viswanath Kraleti <viswanath.kraleti@oss.qualcomm.com>
@vkraleti
distro: add performance optimized distribution variant
e2d2bbe 
Add the qcom-distro-optimized-perf distro variant, which enables
builds with performance optimization features through `optimized-perf`
DISTRO_FEATURE. This variant is useful for boot-time improvements and
other performance-critical optimizations.

Signed-off-by: Viswanath Kraleti <viswanath.kraleti@oss.qualcomm.com>
@vkraleti vkraleti force-pushed the qcom-distro-override branch from b721efb to e2d2bbe Compare January 20, 2026 10:48
quaresmajose
quaresmajose approved these changes Jan 20, 2026
View reviewed changes
Copy link

@quaresmajose quaresmajose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I think the overrides names are a bit long.

@lumag
Copy link
Contributor

lumag commented Jan 20, 2026

How is it going to be used? Do we have a meta-qcom counterpart?
I'm strongly against building or providing extra debug builds.

@anujm1
Copy link
Contributor

anujm1 commented Jan 21, 2026 •
edited
Loading

Right now, the purpose of this debug DISTRO is to enable debug.config in kernel? Should we use the DEBUG_BUILD feature to include the config when it's enabled instead? It'd be useful for a real debug build which isn't limited to just kernel.

@vkraleti
Copy link
Contributor Author

vkraleti commented Jan 21, 2026

How is it going to be used? Do we have a meta-qcom counterpart? I'm strongly against building or providing extra debug builds.

Providing builds with debug options in CI is a non negotiable ask. Without this the whole automation setup around stability testing will fall flat.

qualcomm-linux/meta-qcom#1400 demonstrates how debug distro is going to be used.

Similarly for performance distro builds a few more additional kernel configs mentioned in this meta-qcom issue are going to be pulled in. I'll submit a PR for this as well.

@lumag
Copy link
Contributor

lumag commented Jan 21, 2026

How is it going to be used? Do we have a meta-qcom counterpart? I'm strongly against building or providing extra debug builds.

Providing builds with debug options in CI is a non negotiable ask. Without this the whole automation setup around stability testing will fall flat.

We should not be testing debug builds. The kernel debug options significantly change behaviour of the kernel itself. Those options are for kernel developers who will build their own kernel anyway. Everybody else should be using production builds.

As a simple example, which kernel are you using on your machine? Does it have lockdep enabled? DEBUG_OBJECTS? DEBUG_VM? KASAN or anything similar? Most likely not.

Similarly for performance distro builds a few more additional kernel configs mentioned in this meta-qcom issue are going to be pulled in. I'll submit a PR for this as well.

From this issue, we should be setting "quiet" and use schedutil by default. The rest is invalid.

@pareekpa
Copy link

pareekpa commented Jan 21, 2026 •
edited
Loading

Similarly for performance distro builds a few more additional kernel configs mentioned in this meta-qcom issue are going to be pulled in. I'll submit a PR for this as well.

From this issue, we should be setting "quiet" and use schedutil by default. The rest is invalid.

@lumag , but what about the optimization shown as per this link?

@lumag
Copy link
Contributor

lumag commented Jan 21, 2026

Similarly for performance distro builds a few more additional kernel configs mentioned in this meta-qcom issue are going to be pulled in. I'll submit a PR for this as well.

From this issue, we should be setting "quiet" and use schedutil by default. The rest is invalid.

@lumag , but what about the optimization shown as per this link?

Which options are required to achieve those numbers?

@pareekpa
Copy link

pareekpa commented Jan 21, 2026

Similarly for performance distro builds a few more additional kernel configs mentioned in this meta-qcom issue are going to be pulled in. I'll submit a PR for this as well.

From this issue, we should be setting "quiet" and use schedutil by default. The rest is invalid.

@lumag , but what about the optimization shown as per this link?

Which options are required to achieve those numbers?

Attachemnt in the same link.

@lumag
Copy link
Contributor

lumag commented Jan 21, 2026

Similarly for performance distro builds a few more additional kernel configs mentioned in this meta-qcom issue are going to be pulled in. I'll submit a PR for this as well.

From this issue, we should be setting "quiet" and use schedutil by default. The rest is invalid.

@lumag , but what about the optimization shown as per this link?

Which options are required to achieve those numbers?

Attachemnt in the same link.

This doesn't answer the question. Does CONFIG_PSTORE affect performance? Does CONFIG_ATH12K_DEBUGFS affect it?

Please work with the qcom-next, disabling options which actually significantly affect performance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ricardosalveti ricardosalveti Awaiting requested review from ricardosalveti ricardosalveti is a code owner

@sbanerjee-quic sbanerjee-quic Awaiting requested review from sbanerjee-quic sbanerjee-quic is a code owner

@ndechesne ndechesne Awaiting requested review from ndechesne ndechesne is a code owner

@lumag lumag Awaiting requested review from lumag lumag is a code owner

1 more reviewer

@quaresmajose quaresmajose quaresmajose approved these changes

Reviewers whose approvals may not affect merge requirements

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@vkraleti @lumag @anujm1 @pareekpa @quaresmajose